requests icon indicating copy to clipboard operation
requests copied to clipboard

Published 20 hours ago • verified publisher icon psf

Warn user if environment variables are used

Open Akasurde opened this issue 4 years ago • 7 comments
trafficstars

When session.verify=False, session.trust_env=True and REQUESTS_CA_BUNDLE or CURL_CA_BUNDLE is defined as environment variables then, notify user that requests will use environment variables rather than silently failing.

partially fixes: #3829

Signed-off-by: Abhijeet Kasurde [email protected]

Akasurde avatar May 14 '21 07:05 Akasurde

I spend hours debugging this error. I am aware that this odd behavior is fixed in 3.* release.

Akasurde avatar May 14 '21 07:05 Akasurde

Really nice pr, I checked it – warnings works well, can save a tons of devs time. It would be nice to have more verbose warning text, for those who are not familiar with this problem.

hardenchant avatar May 14 '21 17:05 hardenchant

It would be nice to have more verbose warning text, for those who are not familiar with this problem.

Could you please suggest something? 😂

Akasurde avatar May 21 '21 06:05 Akasurde

Closing/re-opening since I can't trigger CI to run here

sigmavirus24 avatar Jul 07 '21 00:07 sigmavirus24

What's the status of this PR?

intgr avatar Jun 02 '22 07:06 intgr

I am aware that this odd behavior is fixed in 3.* release.

From #6050 looks like 3.x isn't going to happen any time soon, and commitments to fix things in 3.x don't necessarily hold.

intgr avatar Jun 02 '22 07:06 intgr

What's the status of this PR?

I would love to see this PR getting merged. Let me know if you need something from myside.

Akasurde avatar Jun 02 '22 08:06 Akasurde