requests icon indicating copy to clipboard operation
requests copied to clipboard

Fix: #4362 - Redirect resolved even though allow_redirects is set to False causing exception for unsupported connection adapter

Open luckydenis opened this issue 4 years ago • 2 comments

Good evening

The problem was that when checking, we got data that passed the condition test: they contained : , and the request did not start with http. Example 0.0.0.0:8080.

Done:

  • [x] Fix #4362
  • [x] Add and fix tests
  • [x] make test
  • [x] flake8 (diff)

luckydenis avatar Feb 10 '21 13:02 luckydenis

Good evening, @kennethreitz42

Please review my edits when you have some free time

luckydenis avatar Feb 10 '21 13:02 luckydenis

Hi @LuckyDenis, we're looking at this as a possible candidate for 2.27.0. There was some feedback left in July on the current proposal. Would you have time to rebase this change and address that?

nateprewitt avatar Nov 24 '21 20:11 nateprewitt