requests
requests copied to clipboard
Strip whitespace for proxy urls, test for same. #4613
I'm not sure this is the right place to do this operation, but it does solve the problem. Or at least it passes the test that I wrote for it.
Quite likely I'm not reading them correctly, but as far as I can tell the other test methods related to proxies don't test something like a requests.get() call with the expectation of a successful result.
I found a ton of tests for error cases, though, and modeled the test for this situation on those, but it seems like there would be a better way.
Codecov Report
Merging #4627 into master will not change coverage. The diff coverage is
100%.
@@ Coverage Diff @@
## master #4627 +/- ##
=======================================
Coverage 66.62% 66.62%
=======================================
Files 15 15
Lines 1564 1564
=======================================
Hits 1042 1042
Misses 522 522
| Impacted Files | Coverage Δ | |
|---|---|---|
| requests/adapters.py | 70.18% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update fe8290b...a3091c6. Read the comment docs.