httpbin icon indicating copy to clipboard operation
httpbin copied to clipboard

Make flasgger dep optional (#26)

Open AdamWill opened this issue 2 years ago • 4 comments

As discussed in the ticket, the flasgger dep is a pretty heavy one which is not needed when using httpbin as a library. It's only really needed to produce the fancy homepage and API docs for httpbin.org.

This makes the dependency optional, and falls back to the old static HTML page for / if flasgger is not available. The flasgger dependency is moved from the main set of dependencies to the 'mainapp' extras (to ensure we do get the shiny new homepage when we want it).

AdamWill avatar Oct 18 '23 00:10 AdamWill

I tested this by disabling the flasgger dep in pyproject.toml and building a container locally; it works as expected (falls back to the old static page as the front page).

AdamWill avatar Oct 18 '23 00:10 AdamWill

Rebased.

AdamWill avatar Jan 27 '24 18:01 AdamWill

ping? it would be nice not to have to carry this patch downstream any more...

AdamWill avatar Mar 22 '24 16:03 AdamWill

LGTM!

ml31415 avatar Apr 10 '24 06:04 ml31415