MakeMeAdmin icon indicating copy to clipboard operation
MakeMeAdmin copied to clipboard

Added translation: German (de)

Open DeadlyVirez opened this issue 1 year ago • 2 comments

I saw this repository and wanted to contribute.

I unfortunately don't know much about programming, but maybe this can still be merged, after the Resource files have been dealt with (see commit e70ef58fefea7db7b99af2fa313ca7e1917b212c)

DeadlyVirez avatar Apr 21 '24 17:04 DeadlyVirez

I have checked the translations and all are correct.

jwal-d-velop avatar May 27 '24 10:05 jwal-d-velop

brackets have been corrected

DeadlyVirez avatar Jun 07 '24 18:06 DeadlyVirez

Is there an ETA on getting this pull request merged? We'd really need the german translation for some of our users.

If there are any translations that need to be checked, feel free to ping me and I'll gladly assist.

kheldorn avatar Nov 10 '25 14:11 kheldorn

@DeadlyVirez your branch has a conflict, please resolve

OneLiteFeather avatar Nov 11 '25 08:11 OneLiteFeather

Can someone check the following translations?

  • Your administrator rights have expired. You will be logged out.
    • Ihre Administratorrechte sind abgelaufen. Sie werden abgemeldet.
  • There was a failure while configuring XML files.
    • Beim Lesen der XML-Dateien trat ein Fehler auf.
  • Failed to open XML file [3], system error: [2]
    • Konnte XML-Datei [3] nicht öffnen, Systemfehler: [2]
  • Failed to find node: [3] in XML file: [4], system error: [2]
    • Konnte Knoten [3] in der XML-Datei [4] nicht finden, Systemfehler: [2]
  • Failed to save changes to XML file [3], system error: [2]
    • Beim Speichern der Änderungen an der XML-Datei [3] trat ein Fehler auf, Systemfehler: [2]

pseymour avatar Nov 12 '25 04:11 pseymour

Also, there is a DE .msi file here, if someone can check it out.

SHA-256: cede9ccded684a7a385ccf06a0e849dd728670df175ea7a45292b20a13098bca

https://1drv.ms/f/c/5feab1e52fedd235/EnqE4WHIAFhKiPx2V3CLVKsBZXQuNSSWbwdFv9i_Dw6N9w?e=g1h7pc

pseymour avatar Nov 12 '25 05:11 pseymour

  • Your administrator rights have expired. You will be logged out.

    • Ihre Administratorrechte sind abgelaufen. Sie werden abgemeldet.

This is fine.

  • There was a failure while configuring XML files.

    • Beim Lesen der XML-Dateien trat ein Fehler auf.

"Beim Konfigurieren der XML-Dateien trat ein Fehler auf." would be more literal. "Lesen" translates to "reading". I'd prefer something like this though: "Fehler beim Konfigurieren der XML-Datei." (and then also pass the filename to [3]?)

  • Failed to open XML file [3], system error: [2]

    • Konnte XML-Datei [3] nicht öffnen, Systemfehler: [2]

This is fine, I'd probably go for something more like "Fehler beim Öffnen der XML-Datei [3], Systemfehler: [2]".

  • Failed to find node: [3] in XML file: [4], system error: [2]

    • Konnte Knoten [3] in der XML-Datei [4] nicht finden, Systemfehler: [2]

Also fine, but I'd go for something like "Fehler beim Finden von Knoten [3] in XML-Datei [4], Systemfehler: [2]"

  • Failed to save changes to XML file [3], system error: [2]

    • Beim Speichern der Änderungen an der XML-Datei [3] trat ein Fehler auf, Systemfehler: [2]

Fine, same as above though: "Fehler beim Speichern der Änderungen an XML-Datei [3], Systemfehler: [2]".

kheldorn avatar Nov 12 '25 13:11 kheldorn

Also, there is a DE .msi file here, if someone can check it out.

SHA-256: cede9ccded684a7a385ccf06a0e849dd728670df175ea7a45292b20a13098bca

https://1drv.ms/f/c/5feab1e52fedd235/EnqE4WHIAFhKiPx2V3CLVKsBZXQuNSSWbwdFv9i_Dw6N9w?e=g1h7pc

Tried multiple times, no luck. The installer will simply not finish. Running msiexe.exe with the /log parameter does not give anything useful either. It just hangs there. Eventually it will complain that it was not able to start the service and then roll back the installation completely.

Though while the installer is still running the startmenu shortcut is there, service is there but not started. Trying to start the service manually gives the following error:

---------------------------
Dienste
---------------------------
Der Dienst "Make Me Admin" auf "Lokaler Computer" konnte nicht gestartet werden.

Fehler 1064: Bei der Verarbeitung der Steuerungsanforderung ist ein Ausnahmefehler im Dienst aufgetreten.

Trying to use the tool even with the service not running will generate this error when clicking the "Mir Administratorrechte geben" button and confirming with UAC.

Informationen über das Aufrufen von JIT-Debuggen
anstelle dieses Dialogfelds finden Sie am Ende dieser Meldung.

************** Ausnahmetext **************
System.ArgumentException: Die Quelle Make Me Admin ist nicht im Protokoll Applikation, sondern in Protokoll Application registriert. Die Source- und Log-Eigenschaften müssen übereinstimmen. Sie können eine leere Zeichenfolge für Log festlegen, damit Log mit der Source-Eigenschaft übereinstimmt.
   bei System.Diagnostics.EventLogInternal.VerifyAndCreateSource(String sourceName, String currentMachineName)
   bei System.Diagnostics.EventLogInternal.WriteEntry(String message, EventLogEntryType type, Int32 eventID, Int16 category, Byte[] rawData)
   bei System.Diagnostics.EventLog.WriteEntry(String message, EventLogEntryType type, Int32 eventID)
   bei SinclairCC.MakeMeAdmin.ApplicationLog.WriteEvent(String message, EventID id, EventLogEntryType entryType)
   bei SinclairCC.MakeMeAdmin.SubmitRequestForm.get_ReasonDialogSatisfied()
   bei SinclairCC.MakeMeAdmin.SubmitRequestForm.ClickSubmitButton(Object sender, EventArgs e)
   bei System.Windows.Forms.Control.OnClick(EventArgs e)
   bei System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   bei System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   bei System.Windows.Forms.Control.WndProc(Message& m)
   bei System.Windows.Forms.ButtonBase.WndProc(Message& m)
   bei System.Windows.Forms.Button.WndProc(Message& m)
   bei System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

This looks to me like the path to the application eventlog also got translated from "Application" to "Applikation".

kheldorn avatar Nov 12 '25 13:11 kheldorn

Finished translations, changed the application log name back to the English word. Now, I can install it, get admin rights, and lose admin rights, and everything is logged. MSI is in the same OneDrive location.

SHA-256: ffeedf20df543f1fa28ad34c1dd24385d38b67d1519e21672efdeff51d00762d

pseymour avatar Nov 13 '25 00:11 pseymour

Looking good here too. Everything seems to work as intended.

Edit: Oh, just noticed... The "Make Me Admin Remote" tool still has everything in English:

  • Host Name -> Hostname
  • Request Admin Rights -> Administratorrechte anfordern
  • Clear History -> Verlauf löschen

There might be more, but I currently can't test the remote function.

kheldorn avatar Nov 13 '25 09:11 kheldorn

I'm closing this PR, only because the Multilingual App Toolkit (MAT) is deprecated, and Make Me Admin is moving away from it. I did copy @DeadlyVirez's localized strings into MMA's code, so thank you to @DeadlyVirez for submitting these translations. They were accepted, even if I'm not merging this PR.

pseymour avatar Nov 13 '25 19:11 pseymour