protoc-gen-doc icon indicating copy to clipboard operation
protoc-gen-doc copied to clipboard

Published 20 hours ago • verified publisher icon pseudomuto

Support for Oneof in proto files

Open lpabon opened this issue 6 years ago • 10 comments

Also included a template to generate markdown from grpc proto spec

Signed-off-by: Luis Pabón [email protected]

lpabon avatar Jun 28 '18 05:06 lpabon

If this is a more up-to-date protokit compatible 1.1.0 compatible solution to fix the issue #333 I personally would love to see oneOf added.

I raised PR #336 for this problem back in January, and I have been awaiting feedback ever since. I have changed jobs in the last six months, and would no longer have time to commit to making further updates in Go to move my own PR forward, so assuming you are more active in the area I would like to see this effort move to a successful conclusion.

Does this also create a oneOf description from the comments as well as a flag? Do the templates need updating? Is there anything else you could amalgamate from my effort?

jason-fox avatar Jul 06 '18 20:07 jason-fox

@pseudomuto anything blocking this from getting merged? Is it not compatible anymore with the latest version?

Globegitter avatar Jul 16 '19 08:07 Globegitter

Any update?

nicolassleiman avatar Jan 22 '20 15:01 nicolassleiman

Yes, please merge this one

guiguan avatar Apr 02 '20 01:04 guiguan

@pseudomuto could this be merged & released?

nielsvaneck avatar Apr 29 '20 15:04 nielsvaneck

Can we please get this merged @pseudomuto. Anything I can do to help?

ping-localhost avatar May 21 '20 11:05 ping-localhost

Pinging @pseudomuto again. Anything I/we can do to help?

ping-localhost avatar Dec 07 '20 14:12 ping-localhost

At a glance this LGTM 👍 At this point it'll need a rebase

pseudomuto avatar Dec 07 '20 17:12 pseudomuto

At a glance this LGTM 👍 At this point it'll need a rebase

Any chance you're able to do so @pseudomuto / @lpabon. Otherwise I'll take a crack at it :)

ping-localhost avatar Dec 07 '20 17:12 ping-localhost

Submitted https://github.com/pseudomuto/protoc-gen-doc/pull/436 to rebase this PR against current master.

fhalim avatar Jan 12 '21 21:01 fhalim

Hey guys! Just noticed this 4 years later now that I'm back on this again 😄 . Thank you so much for merging!

lpabon avatar Aug 13 '22 05:08 lpabon