torch-stft icon indicating copy to clipboard operation
torch-stft copied to clipboard

can we port this into core?

Open soumith opened this issue 7 years ago • 8 comments

Hey, I was wondering if we can port some refactored form of this into pytorch?

soumith avatar Nov 18 '17 21:11 soumith

(because the repo does not have a license)

soumith avatar Nov 18 '17 21:11 soumith

Oh yeah sure. Would be happy to help with that too! Let me add a license today, which one would work best for PyTorch?

pseeth avatar Nov 18 '17 21:11 pseeth

standard BSD 3 clause, like in pytorch.

thank you.

soumith avatar Nov 18 '17 21:11 soumith

Done!

pseeth avatar Nov 18 '17 21:11 pseeth

thank you.

soumith avatar Nov 18 '17 21:11 soumith

@soumith Is this already in pytorch? Would love to import it directly!

rafaelvalle avatar Jan 09 '18 23:01 rafaelvalle

istft isn't in core pytorch yet, it's being worked upon. Follow https://github.com/pytorch/pytorch/issues/3775 for progress

soumith avatar Jan 10 '18 00:01 soumith

istft isn't in core pytorch yet, it's being worked upon. Follow pytorch/pytorch#3775 for progress

Does it mean that torch.stft is the optimized version of this stft-pytorch repo?

KinWaiCheuk avatar Dec 07 '19 07:12 KinWaiCheuk