iniscan
iniscan copied to clipboard
Duplicate "post_max_size" rule
This rule exists in two places:
- https://github.com/psecio/iniscan/blob/master/src/Psecio/Iniscan/rules.json (twice)
- https://github.com/psecio/iniscan/blob/master/src/Psecio/Iniscan/Rule/MaximumPostSize.php
== Executing INI Scan [09.02.2014 12:47:18] ==
...
FAIL | WARNING | | post_max_size | Unless necessary, a maximum post size of 16M is too large
...
PASS | WARNING | | post_max_size | A maximum post size should be defined to prevent server overload from large requests
FAIL | WARNING | | post_max_size | The max upload size should not be too high, to prevent server overload from large requests
...
The first and third warning are duplicates.
Ah, good point - I guess technically it was meant to be two different checks (one to see if it's set, one to see if it's reasonable) but I see no reason why they couldn't be combined into the MaximumPostSize.php
and the description changed.