wormhole-william-mobile icon indicating copy to clipboard operation
wormhole-william-mobile copied to clipboard

Use official uri-scheme in qr code

Open jonas-w opened this issue 1 year ago • 6 comments

If i see it correctly, you use another uri-scheme than and you asked for the uri-scheme to be standardized https://github.com/magic-wormhole/magic-wormhole-protocols/issues/3. And it got standardized in https://github.com/magic-wormhole/magic-wormhole-protocols/pull/21.

Is there a specific reason, that your uri is different than the standard?

jonas-w avatar Dec 01 '22 02:12 jonas-w

We implemented ours before anything was agreed upon. I don't see much point in supporting the spec until there's other interoperable clients, specifically other clients that support reading qr codes.

psanford avatar Dec 01 '22 05:12 psanford

It does not do proper QR code scanning (yet), but Warp already has a wormhole: URI scheme handler registered. So updating to the new scheme would already be beneficial.

piegamesde avatar Dec 21 '22 22:12 piegamesde

Agreed @piegamesde, as Fina says it is a chicken-egg problem https://gitlab.gnome.org/World/warp/-/issues/22

jonas-w avatar Dec 22 '22 13:12 jonas-w

I'm open to a PR for this.

psanford avatar Dec 22 '22 14:12 psanford

We implemented ours before anything was agreed upon. I don't see much point in supporting the spec until there's other interoperable clients, specifically other clients that support reading qr codes.

@psanford I'm using Rymdport which generates QR codes using the official wormhole-transfer: URI scheme.

When I try to read the QR code using Wormhole William 1.0.8 on Android, it fails because it doesn't recognise the URI. I would be grateful if you could release a new version of Wormhole William with support for the official wormhole-transfer: URI scheme.

vlasky avatar Aug 11 '23 07:08 vlasky

Like I said, I'm open to taking a PR to support both formats here.

psanford avatar Aug 16 '23 23:08 psanford