psalm-vscode-plugin icon indicating copy to clipboard operation
psalm-vscode-plugin copied to clipboard

Published 20 hours ago • verified publisher icon psalm

Folder level settings

Open limarkxx opened this issue 1 year ago • 4 comments

The goal of this PR is to support multi-root workspaces, by changing the scope of configuration setting contribution points to resource instead of the default window, and fully supporting those changes in behavior.

This should allow the user to configure unique psalm language server settings for each workspace folder in a multi-root workspace. Such a configuration should spawn a separate php psalm process for each workspace folder, allowing each workspace to operate using different php versions, different psalm.xml files, etc.

Note: the fixtures folder contains a sample multi-root workspace setup

limarkxx avatar Jul 24 '23 22:07 limarkxx

This looks great. Just need to play with it.

I'm currently writing a test runner extension for php for vscode and I've switched to using resource as well so I agree with this overall

tm1000 avatar Jul 27 '23 16:07 tm1000

I moved all the testing stuff to https://github.com/psalm/psalm-vscode-plugin/pull/269 because it was getting tough to read, and also I don't have any actual tests yet.

limarkxx avatar Jul 27 '23 16:07 limarkxx

https://github.com/vimeo/psalm/issues/10094 prevents multiple LSP instances currently

limarkxx avatar Aug 09 '23 02:08 limarkxx

You can start a codespace in https://github.com/limarkxx/psalm-vscode-plugin/tree/test-folder-level-settings to test with a sample project

limarkxx avatar Aug 09 '23 03:08 limarkxx