Patrick Sadil
Patrick Sadil
> It looks good! There is a small skip that I see in the postcentral gyrus contour. Idk if that can be improved further. And the other contour is hard...
> A follow-up PR can be done to address the small skip to close the contour. I don't think it should block this Just to give an update, I'm now...
Here's a wireframe view of the surface to help clarify the situation:  Vertices in the roi are marked with circles. The circles are orange when they are on the...
Sorry, but hoping to check another implementation detail. I wonder how to handle drawing handle regions that do not share an edge with another vertex in the roi. For example,...
> @psadil thanks for checking that. I think then it would be best to stay consistent with the matplotlib approach and ignore isolated vertices. That would then be more like...
Thanks for all the input. I'll work on something that tries to match the matplotlib approach (unless someone encounters another convention in the meanwhile). FWIW, the behavior of [plot_surf_roi](https://nilearn.github.io/stable/modules/generated/nilearn.plotting.plot_surf_roi.html#nilearn.plotting.plot_surf_roi) includes...
Sorry for being _so_ slow on this. Is there still a need for this functionality?
> @psadil > let me know if you need help with the merge conflicts 🙏🏻 It wasn't pretty, but I merged main and it looks like the diff isn't too...
It looks like those failures for NPY201 are being triggered by different parts of the repo?
I also ran in to this issue after needing to use v7.3 .mat files (first level analysis, but there was a large number of very long runs). Adding try/except blocks...