ps2homebrew
[ISSUE]: add missing VMC group for Grandia 3
Checks
- [x] I have checked existing OPL issues for duplicates and found none
- [x] I am using either OPL latest stable version, or archived version or OPL beta version
Describe the issue
Add missing VMC group for:
SLUS_213.34 Grandia III [Disc 1] SLUS_213.45 Grandia III [Disc 2]
Console model
SCPH-50003
OPL version / revision
OPNPS2LD-v1.2.0-Beta-2212-e215bff
In which device(s) have you experienced this issue?
HDD
Context and extra information
No response
@sync-on-luma should this be added?
It's already on the Wiki page and in the definition files for the XEB+ plugin I developed. It also appears to already be in the source code for OPL, so either the grouping feature as a whole isn't working, or OP did something wrong.
I have nothing to do with OPL's development so someone else here should try to assess why this group isn't working.
I think i see what is happening.
this is the code in vmc_groups.c
static const char *titles_XEBP_000_10[] = { "SCAJ_201.41", "SLPM_659.76", "SLPM_859.76", "SLUS_213.34", "SLUS_213.35"}; static const size_t count_XEBP_000_10 = sizeof(titles_XEBP_000_10) / sizeof(titles_XEBP_000_10[0]);
but Disc 2 of Grandia 3 is actually SLUS_213.45 not SLUS_213.35
hope that is helpful
@MinZe25 The game ID which is in the VMC Group is SLUS_213.35 That belongs to the game The Hustle: Detroit Streets But the Game ID that should be there is the SLUS_213.45, which actually corresponds to the Grandia III (Disc 2)
Just correct the ID https://github.com/ps2homebrew/Open-PS2-Loader/blob/026b9f432f6bc57a7daf11eae965a4df3dd5a84f/src/vmc_groups.c#L1219
Hi. i’m still having the problem where it won’t allow me to add the vmc to disc 2. it says the vmc already exists and prevents me from saving the vmc to that discs config.
@AcidReach I just tested it, and the save file from Disk 1 was recognized normally on Disk 2.
The VMC (XEBP_000.10_0) was assigned automatically, as expected