ps2homebrew
Remove deprecated macro code in order to simply ci.
Pull Request checklist
Note: these are not necessarily requirements
- [x] I reformatted the code with clang-format
- [x] I checked to make sure my submission worked
- [x] I am the author of submission or have permission from the original author
- [ ] Requires update of the PS2SDK or other dependencies
- [ ] Others (please specify below)
Pull Request description
This pr replaces the macro defs: __RTL, IGS, PADEMU to: EXTRA_FEATURES.
Nice one, haven’t looked at it all yet but can we have it off by default.. I think these days most people don’t use them sans pademu but even then most people onto blueretro now
Nice one, haven’t looked at it all yet but can we have it off by default.. I think these days most people don’t use them sans pademu but even then most people onto blueretro now
The problem is rtl and igs will default off aswell.
Nice one, haven’t looked at it all yet but can we have it off by default.. I think these days most people don’t use them sans pademu but even then most people onto blueretro now
The problem is rtl and igs will default off aswell.
Thats fine even less people use those features and if they want them they can grab the extra features build
Nice one, haven’t looked at it all yet but can we have it off by default.. I think these days most people don’t use them sans pademu but even then most people onto blueretro now
The problem is rtl and igs will default off aswell.
Thats fine even less people use those features and if they want them they can grab the extra features build
Yes, also it reduces the size by standard.
@israpps explain me why are you confused? Is there anything wrong? Because i don't see nothing.
@israpps explain me why are you confused? Is there anything wrong? Because i don't see nothing.
I don't like the idea of having PADEMU disabled by default
IGS and RTL, sure. But PADEMU... I think that one should stay
@israpps explain me why are you confused? Is there anything wrong? Because i don't see nothing.
I don't like the idea of having PADEMU disabled by default
IGS and RTL, sure. But PADEMU... I think that one should stay
I think South America guys doesn't have blue-retro.
@israpps explain me why are you confused? Is there anything wrong? Because i don't see nothing.
I don't like the idea of having PADEMU disabled by default IGS and RTL, sure. But PADEMU... I think that one should stay
I think South America guys doesn't have blue-retro.
IGS is useless for average user and RTL is an edge case
PADEMU is a nice feature, either id you can't afford blueretro/brook or if you bought one and you're waiting for it.
Anyways. I would like to hear @AKuHAK opinion
@israpps explain me why are you confused? Is there anything wrong? Because i don't see nothing.
I don't like the idea of having PADEMU disabled by default IGS and RTL, sure. But PADEMU... I think that one should stay
I think South America guys doesn't have blue-retro.
IGS is useless for average user and RTL is an edge case
PADEMU is a nice feature, either id you can't afford blueretro/brook or if you bought one and you're waiting for it.
Anyways. I would like to hear @AKuHAK opinion
Id rather add new flag (like EXTRA_FEATURES) and combine all questionable features inside that flag, and change github action accordingly (for reduxing our enormous compilation job count). So pademu is not a questionable feature.
yea idk, do a lot of people still use pademu? afair both igs and rtl don't really function correctly so those two being bundled together and off by default is fine imo.. will still reduce compilations a bit.. down to 8 instead of current 16.
yea idk, do a lot of people still use pademu?
at least on LATAM it seems so.
yea idk, do a lot of people still use pademu?
at least on LATAM it seems so.
What is this?
PADEMU isnt that rare, some users with broken controller ports uses it.
I will then remove the EXTRA_FEATURES macro containing pademu, but i need to see if it´s ok.
@israpps explain me why are you confused? Is there anything wrong? Because i don't see nothing.
I don't like the idea of having PADEMU disabled by default IGS and RTL, sure. But PADEMU... I think that one should stay
I think South America guys doesn't have blue-retro.
IGS is useless for average user and RTL is an edge case
PADEMU is a nice feature, either id you can't afford blueretro/brook or if you bought one and you're waiting for it.
Anyways. I would like to hear @AKuHAK opinion
I've got the Brook Wingman PS2 adapter but still prefer pademu. I use a DualShock 3 controller because of the analogue buttons. I've found the Brook adapter's vibration implementation to be very poor, both vibration motors only support the highest speed so there's no subtlety. I haven't tried a blue-retro yet... but pressure sensitive buttons and vibration work perfectly with pademu so I use it.
@israpps explain me why are you confused? Is there anything wrong? Because i don't see nothing.
I don't like the idea of having PADEMU disabled by default IGS and RTL, sure. But PADEMU... I think that one should stay
I think South America guys doesn't have blue-retro.
IGS is useless for average user and RTL is an edge case PADEMU is a nice feature, either id you can't afford blueretro/brook or if you bought one and you're waiting for it. Anyways. I would like to hear @AKuHAK opinion
I've got the Brook Wingman PS2 adapter but still prefer pademu. I use a DualShock 3 controller because of the analogue buttons. I've found the Brook adapter's vibration implementation to be very poor, both vibration motors only support the highest speed so there's no subtlety. I haven't tried a blue-retro yet... but pressure sensitive buttons and vibration work perfectly with pademu so I use it.
I´m waiting @AKuHAK to see my pademu code also i will need some testers.
Doh, this PR becames too complex, probably I will redo it from CI perspective by myself
Doh, this PR becames too complex, probably I will redo it from CI perspective by myself
Well i was about to remove at least PADEMU macro and leave as standard to opl, since almost everyone wins.
@
Doh, this PR becames too complex, probably I will redo it from CI perspective by myself
Nowadays is not since i removed pademu macro code which's now become standard to opl. But it's up to you if you want to merge it or not.
Nowadays is not since i removed pademu macro code which's now become standard to opl. But it's up to you if you want to merge it or not.
PADEMU is not a "standard" nowadays, id say that blueretro is more a standard and pademu has big conflicts with mx4sio, so enabling it by default will arise problems for mx4sio users. PADEMU has it usebase but it has issues so cant be enabled by default.
Standard after this pr i meant, sorry for the bad context. If not merged then it's not standard on the means of options page.
Obter o Outlook para Androidhttps://aka.ms/AAb9ysg
From: AKuHAK @.> Sent: Friday, October 25, 2024 3:13:52 PM To: ps2homebrew/Open-PS2-Loader @.> Cc: André Guilherme @.>; Author @.> Subject: Re: [ps2homebrew/Open-PS2-Loader] Remove deprecated macro code in order to simply ci. (PR #1361)
Nowadays is not since i removed pademu macro code which's now become standard to opl. But it's up to you if you want to merge it or not.
PADEMU is not a "standard" nowadays, id say that blueretro is more a standard and pademu has big conflicts with mx4sio, so enabling it by default will arise problems for mx4sio users. PADEMU has it usebase but it has issues so cant be enable by default.
— Reply to this email directly, view it on GitHubhttps://github.com/ps2homebrew/Open-PS2-Loader/pull/1361#issuecomment-2438526420, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASC2KXXJT6CD3467Z5TFCELZ5KC6BAVCNFSM6AAAAABQOQOCQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGUZDMNBSGA. You are receiving this because you authored the thread.Message ID: @.***>