Remove .bmp and .jpg support from OPL.

[Wolf3s]

Pull Request checklist

Note: these are not necessarily requirements

• [x] I reformatted the code with clang-format
• [x] I checked to make sure my submission worked
• [x] I am the author of submission or have permission from the original author
• [ ] Requires update of the PS2SDK or other dependencies
• [ ] Others (please specify below)

Pull Request description

It removes the .jpg and .bmp format as png is very used and optimized than the both formats, This also reduces the executable size. I would like to thanks to: @hardlevel for testing, @KrahJohlito, @AKuHAK, @NathanNeurotic, for ideas. There´s more upcoming...

[Wolf3s]

As I see you combined bmp and jpg removal with png refactoring. Can you split it in different commits? Like first refactor png, second remove jpg/bmp ?

The only thing i can do is add like this then:

Remove .bmp and .jpg support from OPL.
Refactor texture loader to better adapt.
IMPORTANT NOTE: This will affects some art covers and themes so migrate these to .png for
best performance.

[Wolf3s]

As I see you combined bmp and jpg removal with png refactoring. Can you split it in different commits? Like first refactor png, second remove jpg/bmp ?

I usually do as rebase because it´s something that can be easily reduced on the commit.

[Wolf3s]

@AKuHAK https://github.com/ps2homebrew/Open-PS2-Loader/pull/1359/commits/04c2521b31187d0042dfef1f4a975c0824bc14a2

[AKuHAK]

I usually do as rebase because it´s something that can be easily reduced on the commit.

I see :D But png refactoring differs a lot from bmp/jpg removal and can cause different issuess.

[Wolf3s]

I usually do as rebase because it´s something that can be easily reduced on the commit.

I see :D But png refactoring differs a lot from bmp/jpg removal and can cause different issuess.

I will a re-attempt to split then.

[Wolf3s]

@AKuHAK Added 2 commits.

[KrahJohlito]

@AKuHAK Added 2 commits.

theres a mistake in the commit name mate, Remove .BMP and .PNG images support. should be jpg

[Wolf3s]

@AKuHAK Added 2 commits.

theres a mistake in the commit name mate, Remove .BMP and .PNG images support. should be jpg

Typo fixed aswell the downscale, Sorry for the mistyping.

[AKuHAK]

Typo fixed aswell the downscale, Sorry for the mistyping.

Can you redo your PR without all of those "merge" commits? It will break history, if commits are not squashed, but exatly for this PR it is useful to keep them separately. And anyway you fixed typo in separate commit. Can you keep only 2 commits inn history?

[Wolf3s]

Typo fixed aswell the downscale, Sorry for the mistyping.

Can you redo your PR without all of those "merge" commits? It will break history, if commits are not squashed, but exatly for this PR it is useful to keep them separately. And anyway you fixed typo in separate commit. Can you keep only 2 commits inn history?

Unfortunately i had to do 3 since it was conflicting because of the refactor of the png functions.

[israpps]

wasn't BMP the most performant format for non-transparency images??