subg_rfspy icon indicating copy to clipboard operation
subg_rfspy copied to clipboard

endianness of serialized ints is undefined (compiler-dependent)

Open ecc1 opened this issue 8 years ago • 0 comments

In the serial.c code

uint16_t serial_rx_word() {
  return (serial_rx_byte() << 8) + serial_rx_byte();
}

the order of the calls to serial_rx_byte is undefined (up to the C compiler). Similarly for serial_rx_long. So the endianness is not well-defined.

ecc1 avatar Dec 15 '17 04:12 ecc1