metastore icon indicating copy to clipboard operation
metastore copied to clipboard

Published 20 hours ago • verified publisher icon przemoc

Support building on macOS

Open mpctx opened this issue 6 years ago • 2 comments

  • Wrap stat and xattr in ifdef directives.
  • Remove -Bstatic and -Bdynamic arguments in Makefile because the arguments aren't needed and break linking.

Tested on Linux Mint and macOS High Sierra.

mpctx avatar Oct 14 '18 03:10 mpctx

Thanks a lot "mpctx", I just also tested this commit on several Linux systems and a Mac system and it worked nicely. I just merged it into my own fork of metastore (https://gitlab.com/makhlaghi/metastore-fork), combining it with some minor issues I had to fix. I will be using this fork until the new pull requests implemented in the main project.

mohammad-akhlaghi avatar Jan 24 '19 13:01 mohammad-akhlaghi

Thank you, @mpctx, for your metastore contribution.

As it is right now, it's rather a no-go, as adding more #ifdef spaghetti code is undesirable and not maintainable. We have to introduce OS-agnostic API internally and provide OS-specific implementation if common denominator cannot be easily found.

przemoc avatar Apr 08 '21 00:04 przemoc