prysm icon indicating copy to clipboard operation
prysm copied to clipboard

Validator CLI flag for --wallet-dir requires an = when using "accounts list"

Open jyap808 opened this issue 2 years ago ā€¢ 4 comments

šŸž Bug Report

Description

This errors:

$ ./validator-v2.1.4-rc.1-linux-amd64 accounts list --goerli --wallet-dir /somedir
[2022-08-05 21:01:05] ERROR main: unrecognized argument: /somedir

Needs to be specified like this to work:

$ ./validator-v2.1.4-rc.1-linux-amd64 accounts list --goerli --wallet-dir=/somedir

"accounts import" works fine without the "=". For example, this works

$ ./validator-v2.1.4-rc.1-linux-amd64 accounts import --goerli --wallet-dir /somedir --keys-dir /tmp

Has this worked before in a previous version?

Unknown

šŸ”¬ Minimal Reproduction

See description

šŸ”„ Error

See description

šŸŒ Your Environment

Operating System:

Linux

What version of Prysm are you running? (Which release)

v2.1.4-rc.1

jyap808 avatar Aug 05 '22 21:08 jyap808

I think it's a property of how our flag system works, try doing accounts list --wallet-dir /somedir --goerli

james-prysm avatar Aug 10 '22 18:08 james-prysm

Yeah Iā€™m saying the flag parsing should be consistent behavior, not trial and error.

jyap808 avatar Aug 10 '22 18:08 jyap808

still investigating if it's something that'd need to change on ourside or on the cli package

james-prysm avatar Aug 11 '22 03:08 james-prysm

Sorry for the late response, I believe this needs to be addressed at the CLI package side and will take some time before it's addressed along with a few other things. Will keep this open for tracking.

james-prysm avatar Aug 23 '22 01:08 james-prysm

I believe we should have addressed this , can reopen if needed

james-prysm avatar Jul 19 '23 01:07 james-prysm