vmware_exporter icon indicating copy to clipboard operation
vmware_exporter copied to clipboard

Published 20 hours ago • verified publisher icon pryorda

Update vmware_exporter.py to add unit labels

Open CRad14 opened this issue 4 years ago • 4 comments

Changed a few lines which will add a unit label for the vm_perf and host_perf.

I noticed that a number of the metrics did not have units listed fot them and thus it was difficult to adequately use them.

CRad14 avatar Jul 01 '21 17:07 CRad14

Would you be able to update the tests as well?

pryorda avatar Jul 07 '21 14:07 pryorda

Ummm, I can take a look but none of this is my expertise so I may not be able to do it correctly

CRad14 avatar Jul 07 '21 16:07 CRad14

Yeah, I am not sure I am going to be able to update the test. I have been messing around with it for a while and can't even get it to run a successful test before I even make any changes. I tried learning about twisted and the defers but I can't seem to get any of it to work.... Sorry I can't be of more help

CRad14 avatar Jul 19 '21 18:07 CRad14

Ill take a look at this locally inn the near future and hopefully get the tests updated. Thanks for your contribution

pryorda avatar Aug 19 '21 05:08 pryorda