karma icon indicating copy to clipboard operation
karma copied to clipboard

fix(ui): Reverse ToggleIcon

Open VoyTechnology opened this issue 2 years ago • 1 comments

The ToggleIcon works counterintuitive to how you would expect. The chevron direction should indicate what the button SHOULD do, rather that the present state. Currently when the details are hidden, the chevron points up, as if the details view is already seen, and you can hide it, rather than expand it.

The change reverses the chevron direction, so its more intuitive.

VoyTechnology avatar Jul 28 '22 15:07 VoyTechnology

To compare, this is the Settings view, which contains sections which can be expanded, with the correct chevron direction:

image


Meanwhile this is the rotation of the individual alerts when in the expanded detail view:

image

As you can see the chevron points down, but the details are already shown.

VoyTechnology avatar Jul 28 '22 15:07 VoyTechnology

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 26 '22 19:09 github-actions[bot]