karma icon indicating copy to clipboard operation
karma copied to clipboard

Alt+Click filtering doesn't work on Linux

Open tbregolin opened this issue 4 years ago • 6 comments

The Alt+Click shortcut to filter out a label does not work on Firefox, on Linux, because it opens the menu bar. Can this be configurable or based on the user agent?

tbregolin avatar Dec 09 '20 14:12 tbregolin

I'm running Fedora and alt+click works for me in Firefox.

prymitive avatar Dec 10 '20 16:12 prymitive

Ah, I see. Thank you for checking.

Many of the popular window managers (Gnome's, KDE's, Xfce's, Mint's, Openbox, etc) have historically used "Alt + Left Click" to drag windows: https://www.google.com/search?&q=linux+alt-click. I had tried disabling ui.key.menuAccessKeyFocuses in Firefox and the binding in the window manager, but it turns out I hadn't disabled all of necessary ones. If I turn them all off, it works.

I can live with some remapping, so it's up to you if you want to appease the use case or not. Feel free to close.

tbregolin avatar Dec 10 '20 23:12 tbregolin

I might be able to add shortcut configuration if it’s easy enough, need to look into it. Would be a good place to learn all shortcuts

prymitive avatar Dec 12 '20 13:12 prymitive

I managed to add this with some search-and-replace: https://github.com/tbregolin/karma/commit/b15b8511e40ce0c711571cc43564d108886bbbee

It works but, as you can tell, I don't know TypeScript, so it looks funny.

tbregolin avatar Dec 12 '20 13:12 tbregolin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 10 '21 19:02 github-actions[bot]

Hey @prymitive I'm suffering from this issue mainly to my addiction to using the alt key to move my windows. I use MATE which by default sets up the alt key for window moves (as mentioned).

I was able to turn this off and confirm as @tbregolin did that MATE was indeed eating these mouse events.

I'd totally be willing to make a PR but it looks like @tbregolin already hashed a solid amount of this out a while ago. Not sure if they're still interested in pursuing it but I'd be interested in supporting this pull if folks are able to review it (I'm willing to take over if it's no longer active). The linked commit looks reasonably complete, maybe just need to update some tests like this one (and the rest of course) to support the config params.

If you're willing to review and merge, I'm absolutely willing to do some work on this to get it to the finish line with the end goal being at least one alternate key to alt which would be configurable.

fernferret avatar Jul 16 '22 09:07 fernferret

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 26 '22 19:09 github-actions[bot]