Łukasz Mierzwa

Results 133 comments of Łukasz Mierzwa

I've deployed this patch to two instances today, that's on top of v2.37.0-rc1 (+ #10782 & #10709 patches since we have those on top of current v2.36.0). It's working fine...

FYI both instances are working perfectly fine and memory usage reduction is looking great. 26.8M time series instance: ![image](https://user-images.githubusercontent.com/114288/178978588-130c88da-0eec-4105-875f-8fe306fadaa0.png)

Do you it would be feasible to further compress the data? Maybe with some dictionary based compression method (although that seem to require a pre trained dictionary, for example with...

> Divide labels into "target" and "instance" sets - everything for a single scrape gets the same target labels. If `honor_labels: true` is set then each target can return a...

> 1. Pull `__name__` out to a separate string. This saves 9 bytes for the label but adds 16 bytes for a string header. Maybe we can "intern" those strings,...

![Screenshot from 2022-05-17 17-26-00](https://user-images.githubusercontent.com/114288/168861469-f175350e-30d5-49b0-be6d-f8aebcb31753.png) ![Screenshot from 2022-05-17 17-25-45](https://user-images.githubusercontent.com/114288/168861472-370c672d-eeec-41da-a654-4b393332ed8f.png) ![Screenshot from 2022-05-17 17-25-09](https://user-images.githubusercontent.com/114288/168861474-dab29cb4-b465-4423-904c-239abcc2aeb9.png) ![Screenshot from 2022-05-17 17-24-42](https://user-images.githubusercontent.com/114288/168861478-288f834a-38f3-4b65-b440-658d0007dcfe.png)

FYI the main improvement here, I think, is the way writes are scheduled. There's now one big loop that iterates all chunks, locks each one and mmaps them. So we...

More screenshots with Prometheus metrics after deploying latest patch. Query and rule evaluation duration did improve for p90: ![Screenshot from 2022-05-17 21-14-26](https://user-images.githubusercontent.com/114288/168902071-82436f19-b53e-4dd4-8ed5-008a59164110.png) ![Screenshot from 2022-05-17 21-14-08](https://user-images.githubusercontent.com/114288/168902074-d0f3caa6-d2b2-454d-b391-011a181ace1d.png) And I'm no longer...

> Note that the rule until now is that TSDB only uses one core, therefore one go routine. chunk write queue, which was added a few releases ago and disabled...

> Each background thread is 1.33 cores that every user needs to provision, as you need to presume the worst case that they're all active at the same time. As...