karn icon indicating copy to clipboard operation
karn copied to clipboard

"Couldn't retrieve identity from Git repository." if no global signing key is set.

Open seltzered opened this issue 4 years ago • 2 comments

repo.go in https://github.com/prydonius/karn/pull/25 (implement gpg signing) added a getconfig for a signingkey (see repo.go diff). This causes a "Couldn't retrieve identity from Git repository" issue if a user hasn't setup a signingkey at all in their global ~/.gitconfig.

Suggest making this a soft-check, possibly not just for signingkey but for all global gitconfig identity attributes if the intent of karn is to not depend on any global identity aspects.

Workaround for now is to set a global signing key in ~/.gitconfig before using karn.

seltzered avatar Dec 30 '21 01:12 seltzered

Good catch, it shouldn't error on this. Should be a quick patch, @seltzered let me know if you want to submit a fix!

prydonius avatar Jan 03 '22 14:01 prydonius

I'm getting the same issue when name and email are not set in ~/.gitconfig

sidx1024 avatar Mar 09 '23 09:03 sidx1024