Pavol Rusnak comments

Results 504 comments of


                                            Pavol Rusnak

Replace protobuf client implementation with wire

It seems they are not really friends with Gradle, though: https://github.com/square/wire/pulls

Replace protobuf client implementation with wire

OK :-)

Replace protobuf client implementation with wire

I finish even earlier: ``` $ java -jar wire-compiler-2.3.0-RC1-jar-with-dependencies.jar -proto_path=. --java_out=. messages.proto Exception in thread "main" java.lang.IllegalStateException: No sources added. at com.squareup.wire.schema.SchemaLoader.load(SchemaLoader.java:89) at com.squareup.wire.WireCompiler.compile(WireCompiler.java:217) at com.squareup.wire.WireCompiler.main(WireCompiler.java:132) ```

Replace protobuf client implementation with wire

I see. I found the culprit in Wire, I'll post it to the other issue.

Replace protobuf client implementation with wire

Pushed the Wire fix to https://github.com/trezor/trezor-common/commit/224bdde39f23df2c08b3506a0763215ec99ffbbe

Replace protobuf client implementation with wire

Does it still make sense to try to change this?

Replace protobuf client implementation with wire

No worries, I was just wondering if this still makes sense. Let's keep this open for now ...

Replace protobuf client implementation with wire

I don't want to have our Github issues spammed via bots. Feel free to use third party platforms, but don't spam the issues (and transitively my inbox), please.

Jitpack release v2.0.9 failed

I don't want to split the repo into 2 repos.

Add com.github.vlsi.checksum-dependency plugin to verify plugin and dependency artifacts

Hello! This is something we'd like to use. Can you please update this pull request to this feature once Gradle 6.2 stable is released?