PrusaSlicer icon indicating copy to clipboard operation
PrusaSlicer copied to clipboard

Bridge speed should take precedence over special cases like small perimeter speed

Open jschuh opened this issue 4 years ago • 2 comments

This should fix issue #4130 where the small perimeter speed is used instead of the bridge speed. I originally ran into this bug when trying to improve the overhangs on the 3DBenchy door arches (because small perimeter speed was erroneously applied to the curved part of the overhangs).

The change itself is extremely simple. It just always prioritizes the bridge/overhang role over any special-case speed that may be supplied for an extrusion. That seems like the right solution, since generally the bridge/overhang role seems to take priority over other roles elsewhere in the code.

jschuh avatar Feb 14 '21 00:02 jschuh

@bubnikv, this is a very small fix that seems like I trivial "yes or no" situation. Currently the small perimeter speed gets used for a bridge that's a small perimeter. That seems wrong, so the patch flips this, and will use the bridge speed instead in that case.

jschuh avatar Mar 30 '21 15:03 jschuh

Google brought me here when searching for solutions for the same issue. So prusa devs please consider merging this PR! It really helps improving the overhang quality.

mbbill avatar Oct 09 '21 23:10 mbbill

This change seems redundant with the new dynamic overhang speeds and cooling features in 2.6. But, it does still seem like the right default when either of those are disabled, so I figure I won't close it just yet.

jschuh avatar May 20 '23 14:05 jschuh