PrusaSlicer icon indicating copy to clipboard operation
PrusaSlicer copied to clipboard

Published 20 hours ago • verified publisher icon prusa3d

Fix slider dragging when leaving window

Open dunkmann00 opened this issue 9 months ago • 3 comments

There seems to be a bug on macOS where even when the left mouse button is pressed, if you drag the cursor out of the main window, the button will read as not pressed. This will end a drag gesture, which causes unwanted behavior with the layer & gcode sliders if they are still being dragged.

This commit checks if the event is a 'leaving' event, and if so, will use the prior update call's left mouse down state. This avoids the erroneous reading and maintains the drag, if there was one.

Fixes #12879

dunkmann00 avatar Feb 22 '25 01:02 dunkmann00

Before 👎

https://github.com/user-attachments/assets/fc097691-5d1e-45a0-8a7b-693632efed17

After 👍

https://github.com/user-attachments/assets/6622afd5-b41e-4f20-aacf-cfb85c66a3c2

dunkmann00 avatar Feb 22 '25 01:02 dunkmann00

This should be merged ASAP. So incredibly annoying bug and so simple fix.

mottscanley avatar Feb 28 '25 12:02 mottscanley

@lukasmatena Has this PR been reviewed? It would be appreciated to at least get feedback if this is something the Prusa devs are looking to fix?

dunkmann00 avatar Mar 04 '25 19:03 dunkmann00

@SachCZ Is there any update on whether this PR has been looked over?

Thanks.

dunkmann00 avatar Apr 03 '25 18:04 dunkmann00

@rtyr

adamdport avatar Apr 11 '25 16:04 adamdport

As of now we do not want to merge this. In any case I have checked the code. It looks sane and it is an easy enough change. We will hopefully get back to this in the future.

SachCZ avatar Apr 14 '25 20:04 SachCZ

Understood. I certainly hope the team realizes this is quite an annoying bug for us macOS users. Given the linked issue is from 10 months ago combined with the wording of your last sentence, it does not instill much confidence this is the case. We will have to wait and see.

Nonetheless, thank you for providing feedback and for all the work that you put into maintaining PrusaSlicer!

dunkmann00 avatar Apr 15 '25 21:04 dunkmann00

I agree with @dunkmann00 this is a VERY annoying and persistent bug for Mac users and appears to be an easy win based on his analysis and PR code provided here. Not sure why the reluctance on the PS team to pull this in especially based on how many other duplicate issues have been reported by other users.

tverett avatar May 05 '25 15:05 tverett

Zero f*cks given seems to be the reason. Very weird though, wouldn't have expected it from Prusa..

On an unrelated note, I'm having trouble compiling prusaslicer on an M1 MBA.. 😔

mottscanley avatar May 05 '25 20:05 mottscanley

Indifference to the situation is not the reason. I certainly care. We simply hope to get to this in the future.

SachCZ avatar May 07 '25 17:05 SachCZ