Prusa-Firmware icon indicating copy to clipboard operation
Prusa-Firmware copied to clipboard

:construction: WIP: PFW-1460 Update build scripts

Open 3d-gussner opened this issue 10 months ago • 1 comments

3d-gussner avatar Apr 11 '24 17:04 3d-gussner

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 0 0 247784 5653 6168 2539
MK3_MULTILANG 0 0 247082 5662 6870 2530

github-actions[bot] avatar Apr 11 '24 17:04 github-actions[bot]

While testing Windows 10 the build.py script fails during compressing, while the Linux version is working correctly. Looking into that.

3d-gussner avatar Jul 05 '24 08:07 3d-gussner

The problem is not in the build.py. I get the same error when I run the "ALL_MULTILANG" CMake directly from VSCode. (Windows)

All multilang builds for MK25 & MK25S variants fail. (English only builds work fine, so do all builds for MK3 & MK3S variants)

I'll have a closer look on the weekend.

sarusani avatar Jul 05 '24 15:07 sarusani

I think something goes wrong here on windows https://github.com/prusa3d/Prusa-Firmware/blob/MK3/CMakeLists.txt#L594-L595 Can you check on Windows if build\release\release is created which would be https://github.com/prusa3d/Prusa-Firmware/blob/MK3/CMakeLists.txt#L594

Or maybe it takes bit longer on Windows to create the directory and the next line is executed too early?

3d-gussner avatar Jul 05 '24 16:07 3d-gussner

Windows doesn't like the ${variant_name}_${FN_VERSION_SUFFIX}_en*.hex. The wildcard doesn't work. If you (just for testing) change it to ${variant_name}_${FN_VERSION_SUFFIX}_en-ro.hex the build works.

PS: I think the problem is that in linux the filepath is resolved by the shell and then passed to cmake. In windows this doesn't seem to be the case... (Not sure about this 😄)

sarusani avatar Jul 05 '24 16:07 sarusani

@sarusani Please try https://github.com/prusa3d/Prusa-Firmware/pull/4708 + this PR.

3d-gussner avatar Jul 10 '24 08:07 3d-gussner