Prusa-Firmware icon indicating copy to clipboard operation
Prusa-Firmware copied to clipboard

Published 20 hours ago • verified publisher icon prusa3d

Clarify the sound settings

Open DavidWAbrahams opened this issue 5 years ago • 12 comments

I found the sound settings confusing. The name didn't make sense until I read the source code. I suggest some new names here that might be more clear.

Old: Sound [loud, once, silent, mute] My confusion is that the words "silent" and "mute" are too similar. "once" is vague. "loud" is inaccurate, since it doesn't effect the volume.

(modified) proposal: two separate settings. One for the menu sounds and one for alert sounds. Menu beep [on, off] Alerts [repeat, once, off] https://photos.app.goo.gl/5KcHWpXttWe7o8Uh9

DavidWAbrahams avatar Mar 20 '19 05:03 DavidWAbrahams

"Once" actually makes sence as it dont repeat periodic beeping (which is present on filament runout for example) but just beeps once in that case.

PavelSindler avatar Mar 21 '19 18:03 PavelSindler

@PavelSindler shouldn't that be a separate setting then? To me it is kinda weird that some options affect the menu and some effect filament runout.

jurriaan avatar Mar 21 '19 19:03 jurriaan

I agree, there are really two behaviors being controlled by one setting. My ideal would be something like: Alarms [repeating, once, off] Menu beep [on, off]

DavidWAbrahams avatar Mar 21 '19 19:03 DavidWAbrahams

Ok, I've done the much harder change of separating beeps and alerts.

Menu beep [on, off] Alerts [repeat, once, off] https://photos.app.goo.gl/5KcHWpXttWe7o8Uh9

DavidWAbrahams avatar Mar 22 '19 15:03 DavidWAbrahams

@PavelSindler What do you think?

jurriaan avatar Mar 25 '19 19:03 jurriaan

cc @mkbel @XPila

jurriaan avatar Apr 01 '19 19:04 jurriaan

@PavelSindler I see you just released the RC of the MK2 firmware including sound settings. Does it make sense to backport this PR as well?

jurriaan avatar Apr 18 '19 16:04 jurriaan

BTW I've been running this mod on my MK3s for weeks now. Things are working normally. I have muted the menu but left alarms repeating. When my filament runs out, the alarm repeats as expected.

DavidWAbrahams avatar May 12 '19 16:05 DavidWAbrahams

So none of these settings affect the sound level of the M300 gcode output?

larsrc avatar Jul 05 '20 09:07 larsrc

Nope. M300 only changes the duration and frequency. Sound intensity is always the same.

leptun avatar Jul 05 '20 14:07 leptun

Does this need a new advocate to update/rebase?

wilybrace avatar Oct 16 '20 12:10 wilybrace

Yes if you want this to move forward, someone will need to rebase and get a code review. I don't know the process to get a official code review so I gave up.

DavidWAbrahams avatar Oct 16 '20 16:10 DavidWAbrahams

@DavidWAbrahams Thanks for this PR and the idea. At the moment I will close this PR as

  • It would need a re-base
  • It would differ from the 32-bit firmware.

3d-gussner avatar Jul 12 '24 13:07 3d-gussner