Prusa-Firmware-Buddy icon indicating copy to clipboard operation
Prusa-Firmware-Buddy copied to clipboard

[BFW-6065] [BUG] /api/v1/job GET response contains invalid JSON

Open ysmilda opened this issue 5 months ago • 2 comments

Printer model

Mini+

Firmware version

>= v5.0.0-alpha3

Upgrades and modifications

No response

Printing from...

PrusaLink

Describe the bug

When a job is present without stat the returned JSON response for a GET request to /api/v1/job is invalid. It contains a comma at the end of the object which should only be there if the message has stat.

https://github.com/prusa3d/Prusa-Firmware-Buddy/blob/f5a498ab8d2a42341d0dbeb969b7ae047783e860/lib/WUI/link_content/basic_gets.cpp#L434-L438

Moving the JSON_COMMA macro from the end of line 434 to the start of line 436 should fix the message.

How to reproduce

No response

Expected behavior

No response

Files

No response

ysmilda avatar Sep 09 '24 18:09 ysmilda