terraform-provider-infoblox icon indicating copy to clipboard operation
terraform-provider-infoblox copied to clipboard

upgrade to TF .12

Open on4tux opened this issue 6 years ago • 20 comments

according to https://www.terraform.io/upgrade-guides/0-12.html#upgrading-terraform-providers, .11 providers need to upgraded to work with TF .12

on4tux avatar Mar 20 '19 09:03 on4tux

I second this as being very desirable if somebody can manage it please? :) No idea how much work is involved...

GraemeKnights avatar May 31 '19 07:05 GraemeKnights

I have converted this to support terraform v0.12. I have one pull request that needs to be merged first, and then a second PR that builds on top of that.

RobCannon avatar Jun 07 '19 20:06 RobCannon

Plus, I have support for using the new VS Code container build technology. You don't have to worry about what version of Go you have installed locally (or you don't even need it installed!). The container defines the development environment. It works pretty well. So, two more PR's waiting once #56 is accepted.

RobCannon avatar Jun 08 '19 13:06 RobCannon

Thanks @RobCannon Give me a few hours while I catch up to the other issues and PRs and I'll test. :)

JackBracken avatar Jun 10 '19 13:06 JackBracken

Apologies for asking both on here and the pull request, but is this still being considered? Would be really nice to have the provider working with terraform 0.12

surskitt avatar Jul 05 '19 08:07 surskitt

Looking forward to this PR also! Thanks

codyja avatar Jul 10 '19 14:07 codyja

Currently in this boat as well - love the plugin!

zackhorvath avatar Jul 16 '19 03:07 zackhorvath

@RobCannon @prudhvitella You know if that PR is still open? I don't see it in there and I didn't see it being merged. Just hoping to get this provider updated soon. Thanks to all the contributors who've worked on this!

pescetto avatar Aug 05 '19 15:08 pescetto

#56 is still open. I have moved onto another company, so i can't really test this module any more. I have the checkins and can submit them as PRs once #56 is committed, but I can't really support them.

RobCannon avatar Aug 05 '19 22:08 RobCannon

@prudhvitella any time frame on this if possible?

pescetto avatar Aug 09 '19 16:08 pescetto

@RobCannon you mentioned you can't support, would this mean you're not willing and/or able to create a fork and merge both of your pull requests into it?

surskitt avatar Aug 23 '19 16:08 surskitt

My code is all here: https://github.com/RobCannon/terraform-provider-infoblox

There are three branches, one supports modules, one is the update for terraform 0.12 and the third branch adds support for using vscode remote docker support (very handy to make sure all the right requirements are there for building).

RobCannon avatar Aug 23 '19 21:08 RobCannon

Thanks a lot @RobCannon . So do I just need to merge them on top of each other?

surskitt avatar Aug 25 '19 19:08 surskitt

They are all branched from each other. So the vscoderemote has all of the changes.

RobCannon avatar Aug 25 '19 19:08 RobCannon

@RobCannon I've built from your branches and it all works great! I feel bad for taking so long to thank you.

All the more reason to get these PRs merged.

surskitt avatar Sep 02 '19 12:09 surskitt

@prudhvitella any feedback on merging these?

ooOOJavaOOoo avatar Sep 04 '19 22:09 ooOOJavaOOoo

@ooOOJavaOOoo Sorry, I am not familiar "license acceptance error".

RobCannon avatar Sep 06 '19 20:09 RobCannon

@RobCannon sorry, had too many github threads going, getting the nul block error

Error: Provider produced invalid plan

Provider "infoblox" planned an invalid value for module.infoblox_linux.infoblox_record_host.general[0].ipv6addr: attribute representing a list of nested blocks must be empty to indicate no blocks, not null.

Using terraform 0.12.8

ooOOJavaOOoo avatar Sep 10 '19 16:09 ooOOJavaOOoo

Sorry, that it why I can't really support this. I don't have access to an F5 to try to replicate the issue.

Plus, I don't think that issue is a result of my changes. I didn't really make any changes to the core code. It might be due to a change in terraform types, through.

RobCannon avatar Sep 13 '19 00:09 RobCannon

How do you compile this provider?

wenesak avatar Jan 27 '21 09:01 wenesak