prschmid
added requests session to ApiClient
Fixes #62 by adding requests session to ApiClient utility instances. This may be a naive approach, so please let me know if we need additional changes to support this.
- added session instance to ApiClient
- replaced requests.<method> with self.session.<method> calls
- updated mock patches to use util.requests.Session object patches in test_util.py
@seantibor Thank you for your work! We just switched over to using the responses library for better and cleaner testing. I'm going to leave this PR open but, my guess is that when you merge develop in to your branch, this will no longer be relevant.
That being said thank you for your effort in trying to improve this library!
I was able to accept all of the incoming changes from develop, particularly in test_util. The util.ApiClient uses a session object from requests now, which should save some resources and time when making large numbers of requests sequentially.
Ok -- this should be working now. I've implemented the context manager methods, added tests for the context manager and methods, but I have not added tests for the v2 client yet.
Do we want to write V2 client context manager tests too? I've added a lot of tests for the context manager code so I'm not sure if the value is there. Or we could move them to v2 client calls?
Updated session approach to use setter, getter, and deleter property methods.
Tests passed for all supported Python versions. Would like @prschmid to take a look before confirming merge.
Ok -- I think I got it. I've run black on everything and merged develop. Tests are running against 3.6.13 and passing. Let me know if you need anything else.
@seantibor Thanks for fixing up those tests! I just verified and they indeed do pass now. I did notice, however, that there still appears to be one file that is in need of formatting
(~/Development/zoomus:[feature/requests-session]) # black . --check
would reformat /Users/prschmid/Development/zoomus/tests/zoomus/test_util.py
Oh no! 💥 💔 💥
1 file would be reformatted, 95 files would be left unchanged.
Assuming you are running the same version of black as the repo (black==20.8b0) you should be able to just do black . and it will automatically format your files correctly.
Thanks for dealing with these formatting details!
I'm trying to figure out why black keeps formatting this section differently from the command line vs. the pre-commit hook. Possibly a configuration variable I'm missing?
Any ideas?
I'm trying to figure out why black keeps formatting this section differently from the command line vs. the pre-commit hook. Possibly a configuration variable I'm missing?
Any ideas?
Usually when that happens it's due to a black version mismatch. I would be sure to check through and make sure that the versions match up between what you have installed, what's listed in requirements, and what's listed in the pre-commit hook.
Sorry for the many extra commits on this trying to get my pre-commit to work. I finally manually ran black 21.4b and skipped the pre-commit hook that was formatting the test_util.py wrong. I'm not entirely sure why my pre-commit got so messed up but this should bring it back in line.