react-native-shine-button icon indicating copy to clipboard operation
react-native-shine-button copied to clipboard

W & H added to customise

Open ravivlb opened this issue 7 years ago • 1 comments

I have added the width and height to customise based on user

ravivlb avatar Feb 20 '18 04:02 ravivlb

Thanks @ravivlb for the PR.

Definitely it make sense to have a customise layer for the container size. Before merging PR I have couple of questions:

  • You have made changes in style but we are also passing size prop to native. Do we have to change their also? If yes then we can completely get rid of size prop and introduce width & height as default props.
  • Should we add width & height prop to class prop types as well and also provide some default value to the same?
  • Just by changing in style is it working as expected for you?

Thanks Pranav

prscX avatar Feb 20 '18 04:02 prscX