react-native-shine-button icon indicating copy to clipboard operation
react-native-shine-button copied to clipboard

Animation positioning problem.

Open nitishxyz opened this issue 6 years ago • 7 comments

Animation is behind the icon in simulator but on actual device (Android 9) it's a whole line below. Any solutions?

nitishxyz avatar Dec 27 '18 03:12 nitishxyz

My physical device has a notch if that may be the cause of the problem, because animation is playing below the button.

nitishxyz avatar Dec 28 '18 08:12 nitishxyz

I also face this issue. any update on this thread?

Bunhouth99 avatar Feb 09 '20 03:02 Bunhouth99

Could you please share the video of the same. I am not able to visualise the problem.

prscX avatar Feb 09 '20 05:02 prscX

@prscX please check gif file below. i have using custom image. Note: It broken on real device only. old device working fine.(huawei p9 lite)

ezgif com-video-to-gif

Bunhouth99 avatar Feb 09 '20 11:02 Bunhouth99

@Bunhouth99: Got you. I believe, we should render ShineButton post your card is rendered. In componentDidMount you can re-render card component and based on visibility flag you can add ShineButton. Please share your findings.

Thanks </ Pranav >

prscX avatar Feb 09 '20 14:02 prscX

@prscX it still not work. Please kindly check my code below.

const HomeScreen = React.memo(() => { return ( <SafeAreaView style={styles.flex1}> <View style={{ margin: 15 }}> <RNShineButton shape={'heart'} color={'#808080'} fillColor={COLORS.primary} size={moderateScale(28)} /> </View> </SafeAreaView> ); });

ezgif com-video-to-gif (1)

Library issue https://github.com/ChadCSong/ShineButton/issues/48

Bunhouth99 avatar Feb 10 '20 02:02 Bunhouth99

Thanks @Bunhouth99 for sharing the issue link. Once it is fixed I can push the release but until then we need to wait for the fix. Meantime can you try below fix suggested.

issues/48#issuecomment-485328048

Let me know your findings.

Thanks </ Pranav >

prscX avatar Feb 21 '20 07:02 prscX