PXSiriWave9 icon indicating copy to clipboard operation
PXSiriWave9 copied to clipboard

Hardcoded value in (void)updateWithLevel:(CGFloat)level method.

Open sumalla opened this issue 7 years ago • 1 comments

When called with normalizedPowerLevelFromDecibels, the value are not being changed.

-(void)targetMethod:(NSTimer *)timer  {
    // NSLog(@"Siri Timer Called");
    PXSiriWave *siriWave = [timer userInfo];
    [siriWave updateWithLevel: [self _normalizedPowerLevelFromDecibels:self.averagePowerForChannel1]];
}

Corresponding library method has hardcoded value and level value is never used.


- (void)updateWithLevel:(CGFloat)level {
    CGFloat speed = 0.1;
    if (fabs(self.amplitude - _intensity) < speed) {
        self.amplitude = _intensity;
    } else {
        if (self.amplitude < _intensity) {
            self.amplitude += speed;
        } else {
            self.amplitude -= speed;
        }
    }
    
    [self setNeedsDisplay];
}

sumalla avatar Jul 25 '18 00:07 sumalla

Thanks @sumalla for raising your concern. Can you please raise a PR with the fix.

Thanks </ Pranav >

prscX avatar Jul 29 '18 15:07 prscX