prplMesh icon indicating copy to clipboard operation
prplMesh copied to clipboard

Feature/remove network before scan

Open morantr opened this issue 5 years ago • 9 comments

Before BH-scan starts, the repeater should remove existing network configuration so STAs will not be busy in background scans. Add removal of all existing networks before start scanning and thus make the station to be free from background scans.

morantr avatar Jan 05 '20 12:01 morantr

Looks good to me at a low level.

However, do we expect the same to be done for all bwl implementations?

If yes, then I think the disconnect(all) should be done in the backhaul manager itself, not in the dwpal bwl implementation.

If it is only for dwpal (which I think it is), then I think it's better to only implement this for dwpal. In other words, in sta_wlan_hal_dwpal.h:

bool disconnect() override { return disconnect(false); }
bool disconnect(bool all_networks);

It should be done all bwl implementations as long it uses the wpa_supplicant - which they are. But I prefer it will be on the bwl since the backhaul manager shouldn't know about it. It's complicating it unnecessarily. We already do similar things with other bwl api, calling other bwl apis.

morantr avatar Jan 08 '20 09:01 morantr

@morantr what's the status on this one?

tomereli avatar Jan 13 '20 13:01 tomereli

@morantr what's the status on this one?

Still not tested.

morantr avatar Jan 15 '20 18:01 morantr

@morantr Is there any progress on this issue?

If not, could you explain what is blocking you and how we might be able to move forward?

ghost avatar Jan 24 '20 10:01 ghost

@morantr Is there any progress on this issue?

If not, could you explain what is blocking you and how we might be able to move forward?

Currently, this task is on hold since I'm focusing my efforts on building rdkb with prplmesh.

morantr avatar Jan 26 '20 17:01 morantr

@arnout Can we delete this PR and branch now?

tomereli avatar Mar 30 '20 11:03 tomereli

@arnout Can we delete this PR and branch now?

Why are you asking me? This is @morantr's PR...

arnout avatar Mar 30 '20 13:03 arnout

@morantr, can we close this PR?

vitalybu avatar Jul 15 '20 08:07 vitalybu

@morantr, can we close this PR?

Why are you asking me? This is @kantera800's decision...

morantr avatar Jul 16 '20 11:07 morantr