prplMesh icon indicating copy to clipboard operation
prplMesh copied to clipboard

Feature/ppm 30 boardfarm docker compose

Open odkq opened this issue 5 years ago • 3 comments

This branch wraps the boardfarm tests using a python 3.5 script, dctest.py, that runs docker-compose.

The script allows for setting up the bridge with the physical device and cleaning up testing images seamlessly.

As the script is not running inside docker itself, it only uses Python 3.5 (introduced in 2015) features and no external libraries.

odkq avatar Aug 06 '20 16:08 odkq

Also I didn't mention it, but flake8 is complaining so you'll have to address that before you can merge: https://gitlab.com/prpl-foundation/prplMesh/-/jobs/674432838

rmelotte avatar Aug 10 '20 15:08 rmelotte

I also didn't repeat it here (yet?) but in the future please try to describe what you do in the commit description. In addition to the contributing guide you can check in the git history to see what we usually do (reviewing other pull request is also a good way to get familiar with it :-) )

rmelotte avatar Aug 10 '20 15:08 rmelotte

The boardfarm tests were passing (in the sense that there were 2 failing tests and 2 passing ones, the 2 failing ones were disabled on master) with this commit: boardfarm-ci: Commented and reordered Dockerfile : https://gitlab.com/prpl-foundation/prplMesh/-/jobs/680364644

Then all 4 started failing, among which initial AP config failed with Can't find '\(WSC M2 Encrypted Settings\)' with this commit: boardfarm-ci: Scan device names: https://gitlab.com/prpl-foundation/prplMesh/-/jobs/680577567

run-tests however has been failing since the beginning of this branch's history.

rmelotte avatar Aug 11 '20 16:08 rmelotte