prplMesh icon indicating copy to clipboard operation
prplMesh copied to clipboard

refactor ap_metrics

Open RanRegev opened this issue 5 years ago • 6 comments

refactored ap metrics query and response by collecting all responses together before sending to the controller

RanRegev avatar Jun 22 '20 14:06 RanRegev

I would really happy if no refactoring will be done on the backhaul manager until I'll finish moving all flows to tasks as part of the unified agent epic. It is making task more difficult.

morantr avatar Jun 24 '20 06:06 morantr

I would really happy if no refactoring will be done on the backhaul manager until I'll finish moving all flows to tasks as part of the unified agent epic. It is making task more difficult.

@arnout ? @vitalybu ?

RanRegev avatar Jun 24 '20 06:06 RanRegev

I would really happy if no refactoring will be done on the backhaul manager until I'll finish moving all flows to tasks as part of the unified agent epic. It is making task more difficult.

@morantr when do you plan to complete you changes?

vitalybu avatar Jun 24 '20 07:06 vitalybu

I would really happy if no refactoring will be done on the backhaul manager until I'll finish moving all flows to tasks as part of the unified agent epic. It is making task more difficult.

@morantr when do you plan to complete you changes?

It will not be very quick, it will take some time. It is a little bit hard to estimate it right now, but I already started moving the topology flow to a different task, and I planned to do the same on the link metrics right afterward.

morantr avatar Jun 24 '20 07:06 morantr

I would really happy if no refactoring will be done on the backhaul manager until I'll finish moving all flows to tasks as part of the unified agent epic. It is making task more difficult.

@morantr when do you plan to complete you changes?

It will not be very quick, it will take some time. It is a little bit hard to estimate it right now, but I already started moving the topology flow to a different task, and I planned to do the same on the link metrics right afterward.

I understand the feeling, but we can't stop the world while waiting for that to be finished...

But point taken, we'll try to focus on different parts of the code.

arnout avatar Jun 24 '20 07:06 arnout

I would really happy if no refactoring will be done on the backhaul manager until I'll finish moving all flows to tasks as part of the unified agent epic. It is making task more difficult.

@morantr when do you plan to complete you changes?

It will not be very quick, it will take some time. It is a little bit hard to estimate it right now, but I already started moving the topology flow to a different task, and I planned to do the same on the link metrics right afterward.

I understand the feeling, but we can't stop the world while waiting for that to be finished...

But point taken, we'll try to focus on different parts of the code.

@arnout, I don't ask to "stop the world", only refactoring tasks. If it is a bug fix or important feature that is needed for certification or something like that, go ahead, but refactoring tasks are by definition something that could be delayed for the right moment.

morantr avatar Jun 24 '20 08:06 morantr