react-native-inappbrowser icon indicating copy to clipboard operation
react-native-inappbrowser copied to clipboard

Android build breaks due to the release of androidx.browser:browser:1.6.0-beta01 on June 22th

Open xseignard opened this issue 1 year ago • 9 comments

Which platform(s) does your issue occur on?

  • Android

Please, provide the following version numbers that your issue occurs with:

  • androidx.browser:browser:1.6.0-beta01 has been released few days ago, see https://android.googlesource.com/platform/frameworks/support/+/635f86783709c977282f9867d5bcd7662c884df0
  • only compatible with compileSdkVersion 34
  • but most of RN/expo apps rely on compileSdkVersion 33
  • since June 22th, androidx.browser:browser:1.+ resolves to androidx.browser:browser:1.6.0-beta01 due to this code: https://github.com/proyecto26/react-native-inappbrowser/blob/develop/android/build.gradle#L55-L64

Please, tell us how to recreate the issue in as much detail as possible.

Build on android

How to fix?

Add a androidXBrowser = "1.5.0" in your project android/build.gradle:

buildscript {
    ext {
        // ...
        androidXBrowser = "1.5.0"

It already happened before

See this issue: https://github.com/proyecto26/react-native-inappbrowser/issues/386

See this issue: https://github.com/proyecto26/react-native-inappbrowser/issues/298

A more robust solution (e.g. fixed version instead of 1.+) would be great

It happens all the time...

xseignard avatar Jun 23 '23 10:06 xseignard