spec icon indicating copy to clipboard operation
spec copied to clipboard

The spec should define semantics and values for proxy_result_t

Open jpeach opened this issue 3 years ago • 3 comments

The spec mentions that proxy_result_t can express either a success or error status, but does not define how it does that. Looking at the implementation (enum class WasmResult), it seems that 0 is success and there is a set of well-defined non-zero error codes. The spec ought to document all these as part.

jpeach avatar Apr 30 '21 03:04 jpeach

Looks like this is mostly addressed in https://github.com/proxy-wasm/spec/pull/1.

jpeach avatar Apr 30 '21 03:04 jpeach

The vNEXT is unfortunately still a work-in-progress, and not what Envoy and the existing SDKs are implementing, although I'm actively working on fixing that.

Why are you looking at it? Are you implementing either host or another SDK?

PiotrSikora avatar Apr 30 '21 08:04 PiotrSikora

Why are you looking at it? Are you implementing either host or another SDK?

I was reading the spec to get a sense of the underlying concepts and model for writing extensions.

jpeach avatar May 03 '21 01:05 jpeach

I believe this will be resolved by our project overhaul. Please refer to https://github.com/proxy-wasm/spec/pull/39#issuecomment-1577876577 for the context. Thanks!

mathetake avatar Jun 06 '23 04:06 mathetake