proxy-wasm
add all wasi hostcalls used by Go SDK
In #427, a portion of the wasi hostcalls was added, but not all. Now, all the wasi hostcalls have been included, and their stability has been verified in our multiple go 1.24 compiled wasm plugins
Thank you for sending this PR! I will take a look at the code a bit later today, but I was wondering if any of the wasm plugins importing these host calls are public so I can take a look.
I'd be interested to see what logic causes the inclusion of them.
Thank you for sending this PR! I will take a look at the code a bit later today, but I was wondering if any of the wasm plugins importing these host calls are public so I can take a look.
I'd be interested to see what logic causes the inclusion of them.
Sorry for the late reply. Here are some examples of plugin code that has additional WASI dependencies. I've been encountering new WASI dependencies with different plugins, so I included all of them: https://github.com/alibaba/higress/tree/main/plugins/wasm-go/mcp-servers/all-in-one https://github.com/alibaba/higress/tree/main/plugins/wasm-go/extensions/ext-auth
Convert to wat and see the dependencies on some previously unsupported wasi:
@leonm1 There are two more important changes:
- Allow calling poll_oneoff during malloc, because Go calls sleep during GC
- The implementation of poll_oneoff has been changed to no-op instead of error, as the previous implementation would cause a panic during GC
In my example use cases here - https://github.com/shukitchan/ats-wasm-ai-inference/ I find that I need this PR. Otherwise, I am getting the same error as in #308
Thanks for the updates @johnlanni ! It looks like the current presubmit check failures are due to the Github action runners exhausting their allocated disk space. I am looking into obtaining more storage for those.
I have fixed the tests, please help approve the workflow @mpwarres @leonm1