PoshRSJob icon indicating copy to clipboard operation
PoshRSJob copied to clipboard

Very minor formatting changes

Open codykonior opened this issue 6 years ago • 3 comments

Changes proposed in this pull request:

  • Some files had BOM headers, these were removed so they're raw UTF8
  • Replaced the few instances of tabs with spaces
  • In the Pester tests if $PSVersion isn't defined then we define it so users can run Invoke-Pester

Has been tested on (remove any that don't apply):

  • Powershell 5.1
  • Windows 10

codykonior avatar Sep 10 '18 04:09 codykonior

Stripped BOM headers not supported in PSv2, It fail to detect utf8

MVKozlov avatar Sep 10 '18 06:09 MVKozlov

If this were true then the module would not function in the first place, because not every file used a BOM header. Only some files had BOM header and this standardises them.

Second of all the module still executes when run under powershell -version 2.

codykonior avatar Sep 10 '18 06:09 codykonior

May be this is becase it really does not contain any non-ascii symbols, so it non-utf ? :)

But contain BOM on accident, so the topic should sound like 'convert unneeded utf to ascii' ?

MVKozlov avatar Sep 10 '18 07:09 MVKozlov