prowler icon indicating copy to clipboard operation
prowler copied to clipboard

feat(cloudfront): refactor service function names

Open HugoPBrito opened this issue 1 year ago • 1 comments

Context

Service functions in cloudfront service were updated to eliminate the use of magic method syntax, aiming to improve consistency and prevent future errors.

Description

The change was made to avoid conflicts and ensure more reliable and predictable behavior in the service functions by removing that same syntax.

Checklist

  • Are there new checks included in this PR? Yes / No
    • If so, do we need to update permissions for the provider? Please review this carefully.
  • [x] Review if the code is being covered by tests.
  • [x] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

HugoPBrito avatar Aug 26 '24 16:08 HugoPBrito

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.14%. Comparing base (d61e999) to head (c709b9e). Report is 1249 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4867      +/-   ##
==========================================
- Coverage   89.20%   89.14%   -0.06%     
==========================================
  Files         936      936              
  Lines       28614    28614              
==========================================
- Hits        25525    25508      -17     
- Misses       3089     3106      +17     
Components Coverage Δ
prowler 89.14% <100.00%> (-0.06%) :arrow_down:
api ∅ <ø> (∅)

codecov[bot] avatar Aug 26 '24 17:08 codecov[bot]

Please @sergargar @HugoPBrito do not forget to add the reason why this PR was closed.

jfagoagas avatar Sep 11 '24 07:09 jfagoagas

Closed because all of this kind of changes was added in #4910

puchy22 avatar Sep 11 '24 09:09 puchy22