test(cloudstorage): Add remaining GCP tests for CloudStorage checks
Context
There was some checks without tests for CloudStorage in GCP provider.
Description
Added new tests for:
- [x]
cloudstorage_bucket_log_retention_policy_lockcheck - [x]
cloudstorage_bucket_public_accesscheck - [x]
cloudstorage_bucket_uniform_bucket_level_accesscheck
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.54%. Comparing base (
37ade2a) to head (a91f885). Report is 543 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #4464 +/- ##
==========================================
+ Coverage 87.89% 88.54% +0.65%
==========================================
Files 859 893 +34
Lines 26756 27205 +449
==========================================
+ Hits 23517 24090 +573
+ Misses 3239 3115 -124
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is awesome @danibarranqueroo , congrats on your first PR! But please, instead of using
re.search, always assert the whole string. Could you change it for the status_extended? The rest of it is perfect 😄
Thank you @sergargar, I've just made the changes that you suggested :tada:
This is awesome @danibarranqueroo , congrats on your first PR! But please, instead of using
re.search, always assert the whole string. Could you change it for the status_extended? The rest of it is perfect 😄Thank you @sergargar, I've just made the changes that you suggested 🎉
Since changing that something failed, I'll fix it now and come back when it's done