prowler icon indicating copy to clipboard operation
prowler copied to clipboard

fix(opensearch): handle non existing SAMLOptions in domain

Open MrCloudSec opened this issue 1 year ago • 1 comments

Description

Handle non existing SAMLOptions in OpenSearch Domain.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

MrCloudSec avatar May 24 '24 16:05 MrCloudSec

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.31%. Comparing base (ee178c2) to head (d6f2ab0). Report is 450 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4086      +/-   ##
==========================================
- Coverage   86.39%   86.31%   -0.09%     
==========================================
  Files         790      790              
  Lines       24729    24729              
==========================================
- Hits        21364    21344      -20     
- Misses       3365     3385      +20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 16:05 codecov[bot]

Could you please add get() for all the calls in the function? Thanks!

At which calls do you refer? Remember that we have to do this one by one because since we have to make sure to handle each specific case correctly.

MrCloudSec avatar May 27 '24 13:05 MrCloudSec

Could you please add get() for all the calls in the function? Thanks!

At which calls do you refer? Remember that we have to do this one by one because since we have to make sure to handle each specific case correctly.

I meant for all the calls within that function but it's good for now.

jfagoagas avatar May 27 '24 14:05 jfagoagas