prowler icon indicating copy to clipboard operation
prowler copied to clipboard

feat(kubernetes): Handle empty `--kubeconfig-file`

Open pedrooot opened this issue 9 months ago • 2 comments

Context

When running Prowler in Kubernetes, --kubeconfig-file is needed.

Description

Sets the --kubeconfig-file to its default route if it's not set

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pedrooot avatar May 13 '24 10:05 pedrooot

Good idea @pedrooot , but for in-cluster executions, the kubeconfig file is not needed.

sergargar avatar May 15 '24 08:05 sergargar

You can check the documentation for this PR here -> SaaS Documentation

github-actions[bot] avatar May 15 '24 11:05 github-actions[bot]

You can check the documentation for this PR here -> SaaS Documentation

github-actions[bot] avatar May 15 '24 12:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 86.51%. Comparing base (45ccd7e) to head (7bce4eb). Report is 10 commits behind head on master.

Files Patch % Lines
...rowler/providers/kubernetes/kubernetes_provider.py 10.00% 9 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3980   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files         768      768           
  Lines       23899    23901    +2     
=======================================
+ Hits        20677    20679    +2     
  Misses       3222     3222           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 12:05 codecov[bot]