prowler
prowler copied to clipboard
fix(html): Produce valid HTML output in Prowler v3
Description
Prowler (v3) failed to produce valid HTML outputs. There were
- tags not closed
- attributes not placed in double quotes
- text elements not properly HTML-escaped
- superfluous
</div>
elements
Browsers don't seem to mind, but I was experimenting with modifying the generated HTML and ran into issues with XML parsers not accepting the output.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.96%. Comparing base (
15133f2
) to head (4c14af6
). Report is 11 commits behind head on v3.
Additional details and impacted files
@@ Coverage Diff @@
## v3 #3863 +/- ##
==========================================
+ Coverage 85.87% 85.96% +0.08%
==========================================
Files 706 706
Lines 21852 21853 +1
==========================================
+ Hits 18766 18785 +19
+ Misses 3086 3068 -18
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.