prowler icon indicating copy to clipboard operation
prowler copied to clipboard

False positive on ec2_securitygroup_not_used with Batch Compute

Open christiandavilakoobin opened this issue 1 year ago • 6 comments

Steps to Reproduce

If a security group is assigned only on a lambda function, prowlers thinks that is unused and rises an alert.

Expected behavior

Prowler should detect that is assigned to a lambda

Actual Result with Screenshots or Logs

image image

How did you install Prowler?

Docker (docker pull toniblyx/prowler)

Environment Resource

Docker cointainer

OS used

Linux

Prowler version

3.12

Pip version

The one inside docker image

Context

No response

christiandavilakoobin avatar Jan 11 '24 10:01 christiandavilakoobin

Hi @christiandavilakoobin , thanks for reaching us out! However, I cannot reproduce your error and the check works as expected on my side. Make sure that you have the latest version and that you are not getting any error when Prowler retrieves the information from the Lambda functions, using the flag --log-level ERROR.

sergargar avatar Jan 12 '24 09:01 sergargar

Hi @sergargar!

My bad! I just checked again, and I had an exception on this rule, so all of them appear as warning, not only the not used ones. I just saw that on the same screenshot I send this, it says "is used". When I removed the exception it works fine.

christiandavilakoobin avatar Jan 12 '24 11:01 christiandavilakoobin

Awesome, glad that it works. I will close this issue then. Let us know if you have any other issues.

sergargar avatar Jan 12 '24 11:01 sergargar

Hi again,

Regardless, it same to fail on Batch Compute. I have a security group assigned to a batch compute, but Prowler says it is not attached:

image image

christiandavilakoobin avatar Jan 12 '24 11:01 christiandavilakoobin

Hi @christiandavilakoobin, since we still do not cover the batch service, we cannot check that use case. I have include it in our roadmap. Thanks for letting us know!

sergargar avatar Jan 16 '24 13:01 sergargar

Roger that! I'll add those security groups to an exception, meanwhile.

Thank you!

christiandavilakoobin avatar Jan 16 '24 16:01 christiandavilakoobin