kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

FE: fix KC action DELETE to EDIT

Open p-eye opened this issue 2 years ago • 2 comments

  • [ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview) 스크린샷 2023-08-30 오후 5 27 53 in spite of all permission for KC(Kafka Connect), i cannot delete connect KC in each page. (image) because the component has 'DELETE' action which is not in KC action list now, so i changed it to 'EDIT'

i also got the next plan for RBAC https://github.com/provectus/kafka-ui/issues/4170, but i think this is a issue that needs to be fixed for current use thank you for your review. 😃

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • [ ] No need to
  • [X] Manually (please, describe, if necessary)
  • [ ] Unit checks
  • [ ] Integration checks
  • [ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • [X] My changes generate no new warnings (e.g. Sonar is happy)
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes
  • [X] Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

p-eye avatar Aug 31 '23 23:08 p-eye

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 31 '23 23:08 sonarqubecloud[bot]

Is my patch related to this one? I added DELETE action to BE, so I am just not sure if I addressed this case (do not remember): #4250.

oldium avatar Dec 05 '23 06:12 oldium