kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

Published 20 hours ago • verified publisher icon provectus

Format numbers with locale

Open papirosko opened this issue 2 years ago • 10 comments

Issue submitter TODO list

  • [X] I've searched for an already existing issues here
  • [X] I'm running a supported version of the application which is listed here and the feature is not present there

Is your proposal related to a problem?

No response

Describe the feature you're interested in

Number of messages in a topics list should be formatted, e.g. 123,456, and it would be nice to have all values in a table aligned to right

image

Describe alternatives you've considered

No response

Version you're running

56fa824 v0.7.1

Additional context

No response

papirosko avatar Jul 13 '23 08:07 papirosko

Hello there papirosko! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

github-actions[bot] avatar Jul 13 '23 08:07 github-actions[bot]

image Works fine for me. Which browser you're using (name and version)?

Haarolean avatar Jul 13 '23 14:07 Haarolean

its chrome 114.0.5735.198

i can see in your screenshot, that the numbers are not formatted with locale (no delimiters).

The story why the issue was created is this: image image

can you quickly say: on which screenshot the number of messages is greater? each time i have to select 3 digits and count the groups. it will be much easier to read 280 416 611 then 280416611

papirosko avatar Jul 13 '23 15:07 papirosko

@papirosko I see what you mean now. Your screenshot was kinda broken (the number aligned to the right side), I thought that was the problem. Yeah, we might want to format them with a delimiter.

Haarolean avatar Jul 18 '23 06:07 Haarolean

@Haarolean aligning of numbers to the right would be also great.

papirosko avatar Jul 18 '23 07:07 papirosko

Hello I'm a beginner in contributing open source project. I make my first pull request to fix this issue. Please review my PS. Thank in advance! #4272

Ashish2271 avatar Oct 03 '23 22:10 Ashish2271

Hello,

I see this issue is still open. Is anyone working on this or shall I take this?

saket0024 avatar Apr 05 '24 21:04 saket0024

Hey @Ashish2271 and @saket0024, this repo is no longer maintained (#4255), but we'll be happy to accept your contributions in the new repo: https://github.com/kafbat/kafka-ui

Haarolean avatar Apr 12 '24 17:04 Haarolean