kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

Topic custom params are disabled upon editing

Open David-DB88 opened this issue 2 years ago • 8 comments

  • [ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview) fixed disabled item on topic edit

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • [ ] No need to
  • [x] Manually (please, describe, if necessary)
  • [ ] Unit checks
  • [ ] Integration checks
  • [ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • [x] My changes generate no new warnings (e.g. Sonar is happy)
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

David-DB88 avatar Dec 13 '22 17:12 David-DB88

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 12 '23 09:01 sonarqubecloud[bot]

Custom deployment will be available at http://pr3076.internal.kafka-ui.provectus.io

github-actions[bot] avatar Jan 12 '23 11:01 github-actions[bot]

this task has not been completed yet

David-DB88 avatar Jan 12 '23 13:01 David-DB88

@iliax could you help us with logic, please? All custom parameters should be active within dropdown with editing topic settings and also added each custom parameter field should always be displayed within topic profile with edit settings?

armenuikafka avatar Jan 13 '23 08:01 armenuikafka

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Feb 20 '23 15:02 sonarqubecloud[bot]

Custom deployment removed

github-actions[bot] avatar Mar 24 '23 07:03 github-actions[bot]

Is this bug going to be fixed anytime soon?

dmitry-vlt avatar Nov 14 '23 19:11 dmitry-vlt

@dmitry-vlt this repo is not maintained (#4255), see https://github.com/kafbat/kafka-ui instead

Haarolean avatar Apr 18 '24 04:04 Haarolean