kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

Add production/consumption to topic list and topic overview

Open acass91 opened this issue 2 years ago • 10 comments

  • [ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

https://github.com/provectus/kafka-ui/issues/2709

  • Added one column, multiple lines to the topic list for production and consumption
  • Added production and consumption to the topic overview

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • [ ] No need to
  • [x] Manually (please, describe, if necessary)
  • [ ] Unit checks
  • [ ] Integration checks
  • [ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • [x] My changes generate no new warnings (e.g. Sonar is happy)
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged

image

acass91 avatar Oct 20 '22 17:10 acass91

That's largely subjective. We could be going back and forth for days without a specification for the UI. Is there an exact font and font size that you want? I used the defaults for that table.

Is there an example that doesn't use <tr> and <td> because I think that is what's causing the line.

acass91 avatar Oct 21 '22 23:10 acass91

That's largely subjective. We could be going back and forth for days without a specification for the UI. Is there an exact font and font size that you want? I used the defaults for that table.

Is there an example that doesn't use <tr> and <td> because I think that is what's causing the line.

It might be. What's not subjective is that topic row height shouldn't be random and dynamic.

Let's wait for the design in this case. If you're participating in hacktoberfest, I can put an extra label to the PR if you want.

Haarolean avatar Oct 22 '22 16:10 Haarolean

Agreed, the row height can be fixed. Hacktoberfest label would be awesome, thanks.

acass91 avatar Oct 23 '22 01:10 acass91

looks good in general, just a small nit to fix

workshur avatar Nov 07 '22 10:11 workshur

Hey @acass91, we've prepared a design solution here. Please take a look 🙏🏼

Thanks. I added the SVGs for the arrows and changed the heading to 'Speed'. The metrics (bytesInPerSec, bytesOutPerSec) appear to have stopped working since I last ran this.

acass91 avatar Dec 12 '22 00:12 acass91

@acass91 thanks. We'll get back to your PR once we do a release, currently we're in a code freeze stage. Thanks!

Haarolean avatar Dec 12 '22 15:12 Haarolean

@David-DB88 fix the rest when you have time please

Haarolean avatar May 11 '23 10:05 Haarolean

@Haarolean i'll try

David-DB88 avatar May 16 '23 13:05 David-DB88