kafka-ui
kafka-ui copied to clipboard
Add production/consumption to topic list and topic overview
- [ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)
https://github.com/provectus/kafka-ui/issues/2709
- Added one column, multiple lines to the topic list for production and consumption
- Added production and consumption to the topic overview
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
- [ ] No need to
- [x] Manually (please, describe, if necessary)
- [ ] Unit checks
- [ ] Integration checks
- [ ] Covered by existing automation
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
- [x] My changes generate no new warnings (e.g. Sonar is happy)
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged
That's largely subjective. We could be going back and forth for days without a specification for the UI. Is there an exact font and font size that you want? I used the defaults for that table.
Is there an example that doesn't use <tr>
and <td>
because I think that is what's causing the line.
That's largely subjective. We could be going back and forth for days without a specification for the UI. Is there an exact font and font size that you want? I used the defaults for that table.
Is there an example that doesn't use
<tr>
and<td>
because I think that is what's causing the line.
It might be. What's not subjective is that topic row height shouldn't be random and dynamic.
Let's wait for the design in this case. If you're participating in hacktoberfest, I can put an extra label to the PR if you want.
Agreed, the row height can be fixed. Hacktoberfest label would be awesome, thanks.
looks good in general, just a small nit to fix
Hey @acass91, we've prepared a design solution here. Please take a look 🙏🏼
Thanks. I added the SVGs for the arrows and changed the heading to 'Speed'. The metrics (bytesInPerSec, bytesOutPerSec) appear to have stopped working since I last ran this.
@acass91 thanks. We'll get back to your PR once we do a release, currently we're in a code freeze stage. Thanks!
@David-DB88 fix the rest when you have time please
@Haarolean i'll try